[PATCH 2/3] ARM: dts: AM33XX: Add GPMC node
Peter Korsgaard
jacmet at sunsite.dk
Mon Jan 21 16:01:53 EST 2013
>>>>> "Philip" == Philip Avinash <avinashphilip at ti.com> writes:
Philip> From: "Philip, Avinash" <avinashphilip at ti.com>
Philip> Add GPMC data node to AM33XX device tree file.
Philip> Signed-off-by: Philip Avinash <avinashphilip at ti.com>
Philip> ---
Philip> arch/arm/boot/dts/am33xx.dtsi | 12 ++++++++++++
Philip> 1 file changed, 12 insertions(+)
Philip> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
Philip> index eaef5e7..f4209d8 100644
Philip> --- a/arch/arm/boot/dts/am33xx.dtsi
Philip> +++ b/arch/arm/boot/dts/am33xx.dtsi
Philip> @@ -393,5 +393,17 @@
Philip> ti,hwmods = "elm";
Philip> status = "disabled";
Philip> };
Philip> +
Philip> + gpmc: gpmc at 50000000 {
Philip> + compatible = "ti,am3352-gpmc";
Philip> + ti,hwmods = "gpmc";
Philip> + reg = <0x50000000 0x2000>;
Philip> + interrupts = <100>;
Philip> + num-cs = <8>;
Next to Jan's comment about am335x having 7 cs signals, I just realized
the difference in compatible string between the gpmc and elm. The gpmc
refers to a real device (which is afaik how it should be done), but the
elm compatible is simply ti,am33xx-elm.
Presumably it should have been ti,am3352-elm in the binding instead?
Other than that it looks fine.
Acked-by: Peter Korsgaard <jacmet at sunsite.dk>
--
Bye, Peter Korsgaard
More information about the linux-arm-kernel
mailing list