[PATCH v7 09/15] gpio: pl061: set initcall level to module init

[Dinh Nguyen]

Hi Linus,

On Mon, 2013-01-21 at 16:24 +0000, Pawel Moll wrote:
> On Mon, 2013-01-21 at 14:41 +0000, Linus Walleij wrote:
> > On Fri, Jan 18, 2013 at 8:31 AM, Haojian Zhuang
> > <haojian.zhuang at linaro.org> wrote:
> > 
> > > Replace subsys initcall by module initcall level. Since pinctrl
> > > driver is already launched before gpio driver. It's unnecessary
> > > to set gpio driver in subsys init call level.
> > >
> > > Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>
> > 
> > On you platform maybe it works, but have you made sure that nobody
> > else will be affected?
> > 
> > SPEAr of course, then these:
> > 
> > arch/arm/mach-realview/core.c:           * GPIO on PL061 is active,
> > which is the proper
> > arch/arm/mach-socfpga/Kconfig:  select GPIO_PL061 if GPIOLIB
> > 
> > Pawel, Dinh: are you OK with this change?

Still works ok on mach-socfpga.

Dinh
> 
> Hm. Doesn't this make the MMCI probing depending on the module_init
> order? As in: wouldn't it make the mmci probe completely fail (not even
> defer it) if it was called before the pl061? In that case even your,
> Linus, hack with inverting the CD status wouldn't work...
> 
> Pawel
> 
> 
> 
>