[PATCH 5/8] ARM: shmobile: add a GPIO controller DT node for sh7372
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Mon Jan 21 07:23:10 EST 2013
Hi Guennadi,
Thanks for the patch.
On Wednesday 16 January 2013 18:08:14 Guennadi Liakhovetski wrote:
> Add a missing GPIO controller node to sh7372.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski at gmx.de>
> ---
> arch/arm/boot/dts/sh7372.dtsi | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sh7372.dtsi b/arch/arm/boot/dts/sh7372.dtsi
> index 582fdec..7ca9322 100644
> --- a/arch/arm/boot/dts/sh7372.dtsi
> +++ b/arch/arm/boot/dts/sh7372.dtsi
> @@ -19,6 +19,14 @@
> };
> };
>
> + gpio: pfc at e6050000 {
> + compatible = "renesas,pfc-sh7372";
> + reg = <0xe6050000 0x8000>,
> + <0xe605800c 0x20>;
Shouldn't the second one be
<0xe605800c 0x1c>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
I haven't checked the board files, have you made sure that the PFC device
won't be instantiated twice, once from DT and once from board code ?
> soc {
> compatible = "simple-bus";
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
More information about the linux-arm-kernel
mailing list