[PATCH] ARM: remove unnecessary 'select GENERIC_GPIO'

Shawn Guo shawn.guo at linaro.org
Fri Jan 18 02:33:51 EST 2013


On Thu, Jan 17, 2013 at 10:18:13PM +0800, Shawn Guo wrote:
> On Thu, Jan 17, 2013 at 02:36:00PM +0100, Linus Walleij wrote:
> > On Tue, Jan 15, 2013 at 2:13 PM, Shawn Guo <shawn.guo at linaro.org> wrote:
> > 
> > > The only use of GENERIC_GPIO (defined by architecture) in GPIO subsystem
> > > is being selected by GPIOLIB.  Also there are no any use of the option
> > > at architecture level. Only two sub-architectures shmobile and orion
> > > really use the option as below.
> > >
> > >   arch/arm/mach-shmobile/Makefile:obj-$(CONFIG_GENERIC_GPIO)      += $(pfc-y)
> > >   arch/arm/plat-orion/Makefile:orion-gpio-$(CONFIG_GENERIC_GPIO) += gpio.o
> > >
> > > Remove all those unnecessary sub-architecture level selection of
> > > GENERIC_GPIO, which are there only for confusing people.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> > 
> > Acked-by: Linus Walleij <linus.walleij at linaro.org>
> > 
> Thanks, Linus.
> 
> Arnd, Olof,
> 
> Can you please take a look at the patch, and apply it as a cleanup
> if it looks good to you?
> 
The commit log does not look quite good.  Will resend the patch with
a better commit log.

Shawn




More information about the linux-arm-kernel mailing list