[PATCH] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt
Tony Lindgren
tony at atomide.com
Thu Jan 17 12:45:29 EST 2013
* Peter Korsgaard <jacmet at sunsite.dk> [130117 08:46]:
> >>>>> "Michal" == Michal Bachraty <michal.bachraty at gmail.com> writes:
>
> Hi Michael,
>
> Michal> I made changes to cpsw driver two weeks ago, which add support
> Michal> for reading MAC address from CPU and also I posted it to
> Michal> review. You can find patch here :
> Michal> https://patchwork.kernel.org/patch/1966481/ I will create
> Michal> updated patch next week, depended on reactions. Can you try
> Michal> that patch? I'll be glad to hear your opinion.
>
> Thanks, I missed that patch. Functionality wise the patches do the same,
> but I must say I find my patch cleaner, as it doesn't involve any new dt
> bindings or access to the am33xx specific control module registers from
> the cpsw driver.
>
> The way I've handled it is similar to how it is done on atleast one
> other arm subarchicture, see
> arch/arm/mach-mxs/mach-mxs.c::update_fec_mac_prop()
Cool this seems like the cleanest way to deal with it so far. Can
you please resend with also linux-net and DT list Cc:d too?
Also the arch_initcall should be omap_arch_initcall in linux next
for consistency if we ever have SoC specific sections for those.
Regards,
Tony
More information about the linux-arm-kernel
mailing list