[PATCH 1/2 RESEND] gpio: fix warning of 'struct gpio_chip' declaration

Linus Walleij linus.walleij at linaro.org
Thu Jan 17 09:10:15 EST 2013

On Thu, Jan 17, 2013 at 3:03 PM, Shawn Guo <shawn.guo at linaro.org> wrote:

> The struct gpio_chip is only defined inside #ifdef CONFIG_GPIOLIB,
> but it's referenced by gpiochip_add_pin_range() and
> gpiochip_remove_pin_ranges() which are outside #ifdef CONFIG_GPIOLIB.
> Thus, we see the following warning when building blackfin image, where
> GPIOLIB is not required.
>   CC      arch/blackfin/kernel/bfin_gpio.o
>   CC      init/version.o
> In file included from arch/blackfin/include/asm/gpio.h:321,
>                  from arch/blackfin/kernel/bfin_gpio.c:15:
> include/asm-generic/gpio.h:298: warning: 'struct gpio_chip' declared inside parameter list
> include/asm-generic/gpio.h:298: warning: its scope is only this definition or declaration, which is probably not what you want
> include/asm-generic/gpio.h:304: warning: 'struct gpio_chip' declared inside parameter list
> Move pinctrl trunk into #ifdef CONFIG_GPIOLIB to fix the warning,
> since it appears that pinctrl gpio range support depends on GPIOLIB.
> Signed-off-by: Shawn Guo <shawn.guo at linaro.org>

Thanks, patch applied to devel (for-next)

Let's see if something explodes!

Linus Walleij

More information about the linux-arm-kernel mailing list