[PATCH v7 15/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode
Roger Quadros
rogerq at ti.com
Thu Jan 17 07:45:16 EST 2013
On 01/17/2013 02:27 PM, Felipe Balbi wrote:
> On Thu, Jan 17, 2013 at 02:10:18PM +0200, Roger Quadros wrote:
>> On 01/17/2013 01:45 PM, Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Jan 17, 2013 at 01:30:24PM +0200, Roger Quadros wrote:
>>>> @@ -598,6 +639,24 @@ static int usbhs_omap_probe(struct platform_device *pdev)
>>>> clkname, PTR_ERR(pclk));
>>>> else
>>>> omap->utmi_clk[i] = pclk;
>>>> +
>>>> + snprintf(clkname, sizeof(clkname),
>>>> + "usb_host_hs_hsic480m_p%d_clk", i + 1);
>>>
>>> do we really need to know the exact clock node name ?
>>>
>> I think so. Do you have a better suggestion?
>
> update CLKDEV entries ? I mean, what if we have a new OMAP or AMxxxx
> device with a different clock name ? That will be a big bummer.
>
In that case we simply need to add the relevant CLKDEV entries/aliases
for the new platform. I don't think anything needs to be changed in the
driver. We are still using clk_get(dev, clk_name), so the CLKDEV
framework will return the best matching clock for the device.
--
cheers,
-roger
More information about the linux-arm-kernel
mailing list