[PATCH v7 17/22] mfd: omap-usb-host: clean up omap_usbhs_init()
Roger Quadros
rogerq at ti.com
Thu Jan 17 07:13:05 EST 2013
On 01/17/2013 01:48 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Jan 17, 2013 at 01:30:26PM +0200, Roger Quadros wrote:
>> + if (is_omap_usbhs_rev1(omap))
>> + reg = omap_usbhs_rev1_hostconfig(omap, reg);
>> + else if (is_omap_usbhs_rev2(omap))
>> + reg = omap_usbhs_rev2_hostconfig(omap, reg);
>
> Any way you could maybe:
>
> rev = omap_usbhs_revision(omap)
> switch(rev) {
> case REV1:
> foo();
> break;
> case REV2:
> bar();
> break;
> default: /* highest revision */
> baz();
> }
>
> could be done in a later patch however.
>
I'll fix it in this series.
--
cheers,
-roger
More information about the linux-arm-kernel
mailing list