[PATCH] [RFC] ARM: compile fix for DEBUG_LL=y && MMU=n

Olof Johansson olof at lixom.net
Wed Jan 16 17:31:44 EST 2013


On Wed, Jan 16, 2013 at 03:32:06PM +0100, Uwe Kleine-König wrote:
> debug_ll_addr is only used on machines with an MMU so it can be #ifdef'ed
> out safely. This fixes:
> 
> arch/arm/kernel/debug.S: Assembler messages:
> arch/arm/kernel/debug.S:104: Error: too many positional arguments
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Cc: Rob Herring <rob.herring at calxeda.com>
> Cc: Stephen Warren <swarren at nvidia.com>
> Cc: Olof Johansson <olof at lixom.net>
> ---
> The obvious alternative fix is to make addruart on !MMU take 3
> arguments, too.
> 
> The problem was introduced in
> 
> 	e5c5f2a (ARM: implement debug_ll_io_init())
> 
> which appeared in v3.8-rc1.

Since we introduced the breakage in arm-soc, I've picked up the fix (I guess
it could have gone through Russell's tree as well though).

I've added the reference to the introducing commit, and the acks/review tags.

Adding a defconfig for a !MMU platform seems like a good idea, since there's
several of us who make sure that there is build coverage of the defconfigs and
follow up on most of the breakage. Feel free to send one in for 3.9.


-Olof



More information about the linux-arm-kernel mailing list