[PATCH] ARM: kernel: DT cpu map validity check helper function
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Jan 11 11:30:57 EST 2013
On Fri, Jan 11, 2013 at 04:17:38PM +0000, Lorenzo Pieralisi wrote:
> This patch implements a helper function that platforms can call to check
> whether DT based cpu map initialization and cores count were completed
> successfully.
Umm, are you sure this works? Two problems here:
- the kernel boot marks the booting CPU (in our case, CPU0) as present,
possible and online before arch code gets called. smp_init_cpus()
will be called with the maps already initialized per that.
- this really needs to be paired with a patch showing how you intend it
to be used; merely adding the helper without any sign of it being used
means it's just bloat which may not end up being used.
More information about the linux-arm-kernel
mailing list