[PATCH 2/3] ARM: Orion: Bind the orion bridge interrupt controller through DT

Jason Gunthorpe jgunthorpe at obsidianresearch.com
Thu Jan 10 13:48:32 EST 2013

On Thu, Jan 10, 2013 at 10:54:13AM +0100, Sebastian Hesselbarth wrote:

> >>>Kirkwood is already OK WRT the 0 IRQ, it is handled internally to
> >>>get_irqnr_and_base.
> >>>
> >>>So, I will suggest to please test on dove as-is...
> >>
> >>Did you have a chance to test this on dove?
> >
> >Hi Jason
> >
> >We discussed this a little and I prefer Sebastians implementation.
> >
> >Sebastian, do you have time to work on your code and get it ready?
> Jason, Andrew,
> we chose to jump to irqchip instead of fixing old code. I thought
> Jason Gunthorpe volunteered to get it ready? Moving to irqchip also
> requires clksrc-orion or reimplementing orion into clksrc-mvebu.

I looked into it, but at the time there was so much churn going into
the merge window that it was too much to tackle, then there was/is
holidays for me :) Feburary would probably be the soonest I could
actually get my systems running the latest kernels and do any work on
this subject.

The drivers Sebastian posted looked close to what I posted, a few
things like edge interrupts should be copied over from my patches

The irqchip can be done prior to the timer, if the bridge cause
decoding is left disabled in the DT then the existing timer should
still work..

There is a bunch of prep stuff that may still be pending:
 - Fixup remaining drivers (usb? ethernet?) to have DT bindings and
   get the IRQ number through DT
 - Fixup the GPIO driver to dynamically allocate IRQs rather than
   having a hardwired start (did the pinctl change fix this?)
 - Separate the non-DT and DT IRQ related stuff, the IRQ numbering
   changes with the irqchip driver's dynamic allocation. This solves
   the 0 IRQ problem..
 - Remove non-DT code? Andrew was talking about this..


More information about the linux-arm-kernel mailing list