[PATCH 2/2] Fix phy_attach - forward dev_flags for phy_attach
Florian Fainelli
florian at openwrt.org
Thu Jan 10 09:40:36 EST 2013
Le 01/10/13 13:00, Kosta Zertsekel a écrit :
> Change-Id: Ie3191f95c36eada6d0c673460de5393641128182
> ---
> drivers/net/ethernet/marvell/pxa168_eth.c | 2 +-
> net/dsa/slave.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
I think that you should have actually two patches, one for pxa168_eth
and one for net/dsa/slave.c.
Also, please prefix your patches with what was usually used on these
files before: "pxa168_eth:" and "net: dsa:" respectively.
By the way, most, if not all of the phy_connect() users in
drivers/net/ethernet/ also do not ensure they pass the phy device flags,
so you might want to fix this globally and not just for Marvell driver.
Thanks.
--
Florian
More information about the linux-arm-kernel
mailing list