[PATCH v4 13/19] ARM: remove mach .handle_irq for VIC users

Linus Walleij linus.walleij at linaro.org
Thu Jan 10 06:00:14 EST 2013

On Thu, Jan 3, 2013 at 10:48 PM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Thursday 03 January 2013, Rob Herring wrote:
>> From: Rob Herring <rob.herring at calxeda.com>
>> Now that the VIC initialization sets up the handle_arch_irq pointer, we
>> can remove it for all machines and make it static.
>> Signed-off-by: Rob Herring <rob.herring at calxeda.com>
>> Cc: Ryan Mallon <rmallon at gmail.com>
>> Cc: Russell King <linux at arm.linux.org.uk>
>> Cc: Hubert Feurstein <hubert.feurstein at contec.at>
>> Cc: Alessandro Rubini <rubini at unipv.it>
>> Cc: STEricsson <STEricsson_nomadik_linux at list.st.com>
>> Cc: Ben Dooks <ben-linux at fluff.org>
>> Cc: Kyungmin Park <kyungmin.park at samsung.com>
>> Cc: Shiraz Hashim <shiraz.hashim at st.com>
>> Cc: Rajeev Kumar <rajeev-dlh.kumar at st.com>
>> Acked-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>> Acked-by: Jamie Iles <jamie at jamieiles.com>
>> Acked-by: Linus Walleij <linus.walleij at linaro.org>
>> Acked-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
>> Acked-by: Viresh Kumar <viresh.kumar at linaro.org>
>> Acked-by: Kukjin Kim <kgene.kim at samsung.com>
>> Acked-by: Olof Johansson <olof at lixom.net>
> Acked-by: Arnd Bergmann <arnd at arndb.de>

Acked-by: Linus Walleij <linus.walleij at linaro.org>

>> +static void vic_handle_irq(struct pt_regs *regs);
>> +
>>  /**
>>   * vic_init2 - common initialisation code
>>   * @base: Base of the VIC.
>> @@ -466,7 +468,7 @@ static int handle_one_vic(struct vic_device *vic, struct pt_regs *regs)
>>   * Keep iterating over all registered VIC's until there are no pending
>>   * interrupts.
>>   */
>> -asmlinkage void __exception_irq_entry vic_handle_irq(struct pt_regs *regs)
>> +static asmlinkage void __exception_irq_entry vic_handle_irq(struct pt_regs *regs)
>>  {
>>         int i, handled;
> I'm a big fan of the "no forward function declarations in .c files" rule. Can
> I convince to reorder the file contents instead to avoid the forward declaration?

And +1 on this comment.

Linus Walleij

More information about the linux-arm-kernel mailing list