[PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe

vipul kumar samar vipulkumar.samar at st.com
Mon Jan 7 22:52:03 EST 2013


On 1/7/2013 11:49 PM, Viresh Kumar wrote:
> On 7 January 2013 20:43, Marek Vasut<marex at denx.de>  wrote:
>>>> The new
>>>> behaviour is the expected one and copies the behavior of
>>>> platform_data-based probe.
>>>
>>> Blindly copying platform data behaviour to DT bindings is seldom a good
>>> idea.
>>
>> Do you have suggestions how to pass these information? I suspect the irq-over-
>> gpio property can be killed, since if irq-gpios prop is there, it implies irq-
>> over-gpio anyway.
>
> Both can be killed. gpios as interrupt lines can be requested as:
>
>   interrupt-parent =<&gpio-controller>;
>   interrupts =<25 0x1>;
>
> and probably the stmpe driver doesn't have to bother at all if
> interrupt was over gpio
> or not.
> .
>

Yes, both can be killed and similarly we did for spear1340 machine but 
some how we missed it on spear320-hmi.

Regards
Vipul Samar




More information about the linux-arm-kernel mailing list