[PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe
lee.jones at linaro.org
Mon Jan 7 10:03:41 EST 2013
On Mon, 07 Jan 2013, Marek Vasut wrote:
> In case of a DT-based probe of the stmpe MFD driver, the irq_gpio was zero,
> which resulted in the driver failing to probe.
> Implement DT properties "irq-over-gpio" and "irq-gpios" which are already used
> in "arch/arm/boot/dts/spear320-hmi.dts" to circumvent these problems.
This must have slipped through the gaps. It should be removed.
> The new
> behaviour is the expected one and copies the behavior of platform_data-based
Blindly copying platform data behaviour to DT bindings is seldom a good idea.
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Lee Jones <lee.jones at linaro.org>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Samuel Ortiz <sameo at linux.intel.com>
> Cc: Vipul Kumar Samar <vipulkumar.samar at st.com>
> Cc: Viresh Kumar <viresh.kumar at linaro.org>
> drivers/mfd/stmpe.c | 5 +++++
> 1 file changed, 5 insertions(+)
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index 4b11202..fb9cd6f 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -1018,6 +1018,11 @@ void stmpe_of_probe(struct stmpe_platform_data *pdata, struct device_node *np)
> pdata->id = -1;
> pdata->irq_trigger = IRQF_TRIGGER_NONE;
> + pdata->irq_over_gpio = of_get_property(np, "irq-over-gpio", NULL);
This is a new DT binding and you haven't provided any documentation for it.
Also, there is no reason for the binding to exist.
Lots of drivers use GPIO pins as IRQs.
> + pdata->irq_gpio = of_get_named_gpio(np, "irq-gpios", 0);
> + if (!gpio_is_valid(pdata->irq_gpio))
> + pdata->irq_gpio = -1;
> of_property_read_u32(np, "st,autosleep-timeout",
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
More information about the linux-arm-kernel