[PATCH] Add apf51 basic support

[Shawn Guo]

On Sun, Jan 06, 2013 at 05:19:13PM +0100, Laurent CANS wrote:
> 2013/1/3 Shawn Guo <shawn.guo at linaro.org>:
> > On Wed, Dec 19, 2012 at 09:39:36PM +0100, Sascha Hauer wrote:
> >> On Sun, Dec 16, 2012 at 10:49:51PM +0100, Laurent Cans wrote:
> >> > Signed-off-by: Laurent Cans <laurent.cans at gmail.com>
> >> > Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou at armadeus.com>
> >> > ---
> >> > +   clocks {
> >> > +           #address-cells = <1>;
> >> > +           #size-cells = <0>;
> >> > +
> >> > +           ckih1 {
> >> > +                   compatible = "fsl,imx-ckih1", "fixed-clock";
> >> > +                   clock-frequency = <0>;
> >> > +           };
> >> > +
> >> > +           osc {
> >> > +                   compatible = "fsl,imx-osc", "fixed-clock";
> >> > +                   clock-frequency = <33554432>;
> >> > +           };
> >>
> >> These compatible properties shouldn't be necessary, right?
> >>
> > Use node path instead?  But imx51 clock driver is already using
> > compatible property to identify the clocks.
> >
> > Shawn
> >
> 
> Hi shawn,
> 
> I don't understand your remarks.
> 
Or I misunderstood Sascha's comment?  I thought he was asking you to
remove those compatible properties, and I do not understand how that
would work, since clock code is looking for the node using the
compatible property.

Shawn

> The method used to define clocks is incorrect? What is the recommended
> method to define clocks?
> 
> Laurent