[PATCH v6 5/8] document: devicetree: bind pinconf with pin single
Tony Lindgren
tony at atomide.com
Thu Jan 3 19:25:56 EST 2013
* Tony Lindgren <tony at atomide.com> [121222 09:14]:
> * Haojian Zhuang <haojian.zhuang at linaro.org> [121221 22:35]:
> > > pinctrl-single,input-schmitt = <defval regmask enableval disableval>;
> > In Marvell silicons, input-schmitt trigger could be configured as
> > high-edge, low-edge or both
> > detect. So enableval can't cover this usage.
Hmm assuming that's two bits for configuring it, can you make both
detect same as:
pinctrl-single,input-schmitt-high-edge = <enableval disableval regmask>;
pinctrl-single,input-schmitt-low-edge = <enableval disableval regmask>;
Or does that not work for you?
To me it looks like we should just standarize on the following:
pinctrl-single,bias-enable = <enableval disableval regmask>;
pinctrl-single,bias-pullup = <enableval disableval regmask>;
pinctrl-single,bias-pulldown = <enableval disableval regmask>;
pinctrl-single,input-schmitt = <enableval disableval regmask>;
pinctrl-single,input-schmitt-high-edge = <enableval disableval regmask>;
pinctrl-single,input-schmitt-low-edge = <enableval disableval regmask>;
...
pinctrl-single,comparator-enable = <enableval disableval regmask>;
pinctrl-single,comparator-status = <regmask>; /* read only status bits */
So no need to stuff the defval there AFAIK.
Regards,
Tony
More information about the linux-arm-kernel
mailing list