[PATCH v4 09/19] ARM: use common irqchip_init for GIC init
Arnd Bergmann
arnd at arndb.de
Thu Jan 3 16:41:19 EST 2013
On Thursday 03 January 2013, Rob Herring wrote:
> @@ -637,8 +638,6 @@ static int __init combiner_of_init(struct device_node *np,
> }
>
> static const struct of_device_id exynos_dt_irq_match[] = {
> - { .compatible = "arm,cortex-a9-gic", .data = gic_of_init, },
> - { .compatible = "arm,cortex-a15-gic", .data = gic_of_init, },
> { .compatible = "samsung,exynos4210-combiner",
> .data = combiner_of_init, },
> {},
> @@ -654,8 +653,10 @@ void __init exynos4_init_irq(void)
> if (!of_have_populated_dt())
> gic_init_bases(0, IRQ_PPI(0), S5P_VA_GIC_DIST, S5P_VA_GIC_CPU, gic_bank_offset, NULL);
> #ifdef CONFIG_OF
> - else
> + else {
> + irqchip_init();
> of_irq_init(exynos_dt_irq_match);
> + }
> #endif
Is this an equivalent change? I thought you are supposed to call of_irq_init
only once so it can see the entire hierarchy. Or is it ok as long as the
top-level controllers are probed first?
Arnd
More information about the linux-arm-kernel
mailing list