[PATCH v4 01/19] irqchip: add basic infrastructure

Arnd Bergmann arnd at arndb.de
Thu Jan 3 16:36:51 EST 2013


On Thursday 03 January 2013, Rob Herring wrote:
> So, upon the suggestion of Rob Herring and Arnd Bergmann, this commit
> introduces a small infrastructure that defines a central
> irqchip_init() function in drivers/irqchip/irqchip.c, which is meant
> to be called as the ->init_irq() callback of ARM platforms. This
> function calls of_irq_init() with an array that will progressively
> contain the compatible strings of each irq controller driver, and also
> a reference to the initialization functions of such drivers. The
> drivers/irqchip/irqchip.h header file, currently empty, is added to
> allow irq controller drivers to expose their initialization function
> to the main irqchip.c file. Note that the irq controller driver
> initialization function is responsible for setting the global
> handle_arch_irq() variable, so that ARM platforms no longer have to
> define the ->handle_irq field in their DT_MACHINE structure.

This changeset text looks like it refers to an older version of the
patch that did not have the section magic yet.

> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Reviewed-by: Stephen Warren <swarren at wwwdotorg.org>
> Reviewed-by: Rob Herring <rob.herring at calxeda.com>

I actually liked the old version better because it was more obvious
to the casual reader how it fits together, but I'm not going to
stand in the way if other people like it this way.

Acked-by: Arnd Bergmann <arnd at arndb.de>



More information about the linux-arm-kernel mailing list