[PATCH 3/3] ARM: OMAP: SRAM: resolve sparse warnings
Tony Lindgren
tony at atomide.com
Tue Jan 1 13:15:09 EST 2013
* Paul Walmsley <paul at pwsan.com> [121223 17:30]:
> Commit bb77209432873214a796a70a4539e4ebdf3feb54 ("ARM: OMAP: Move
> omap2+ specific parts of sram.c to mach-omap2") adds some new sparse
> warnings:
>
> arch/arm/plat-omap/sram.c:43:6: warning: symbol 'omap_sram_push_address' was not declared. Should it be static?
> arch/arm/plat-omap/sram.c:65:6: warning: symbol 'omap_sram_reset' was not declared. Should it be static?
> arch/arm/plat-omap/sram.c:73:13: warning: symbol 'omap_map_sram' was not declared. Should it be static?
>
> Fix by creating a temporary header file containing prototypes for
> these SRAM functions - needed until the SRAM code is moved to
> drivers/. arch/arm/plat-omap/include/plat/sram.h can't be added due
> to ARM CONFIG_ARCH_MULTIPLATFORM restrictions on the use of the "plat/"
> include path shortcut.
Here too we should just include <plat/sram.h>, that's OK for the
multiplatform builds. Just drivers will not have it available.
Then eventually the issue disappears as this code becomes a regular
device driver.
Regards,
Tony
More information about the linux-arm-kernel
mailing list