[PATCH 24/35] mfd: ab8500: Remove unnecessary 'struct device' declaration

Arnd Bergmann arnd at arndb.de
Mon Feb 25 09:33:35 EST 2013


On Friday 15 February 2013, Lee Jones wrote:
> A recent patch saw the device.h include being removed from some other
> include files and replaced with a 'struct device' declaration instead.
> However, neither the include nor the declaration is actually required.
> 
> Signed-off-by: Lee Jones <lee.jones at linaro.org>
> ---
>  include/linux/mfd/abx500.h |    2 --
>  1 file changed, 2 deletions(-)

In my copy of the file, we the declaration


int ab8500_bm_of_probe(struct device *dev,
                       struct device_node *np,
                       struct abx500_bm_data *bm);



and others that use 'struct device'. C99 requires that a struct is declared
in advance  before you use it in a function declaration.

	Arnd



More information about the linux-arm-kernel mailing list