[PATCH] arm64: compat_sys_sigsuspend: init local blocked mask not current process mask
Ryan Harkin
ryan.harkin at linaro.org
Mon Feb 25 07:40:07 EST 2013
The original version changed the signal mask in the current process, and then passed an unitialized variable to sigsuspend, which in turn, besides the other work, sets current->blocked.
The value of mask, passed from a process, was effectively overwritten by some random value. If the random value was zero, all signals were blocked and pipes no longer work.
Signed-off-by: Ryan Harkin <ryan.harkin at linaro.org>
---
arch/arm64/kernel/signal32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/signal32.c b/arch/arm64/kernel/signal32.c
index a4db3d2..0bc9461 100644
--- a/arch/arm64/kernel/signal32.c
+++ b/arch/arm64/kernel/signal32.c
@@ -347,7 +347,7 @@ asmlinkage int compat_sys_sigsuspend(int restart, compat_ulong_t oldmask,
{
sigset_t blocked;
- siginitset(¤t->blocked, mask);
+ siginitset(&blocked, mask);
return sigsuspend(&blocked);
}
--
1.7.9.5
More information about the linux-arm-kernel
mailing list