[RFC/PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors

Kevin Hilman khilman at linaro.org
Fri Feb 22 00:57:46 EST 2013


Frederic Weisbecker <fweisbec at gmail.com> writes:

> 2013/2/21 Frederic Weisbecker <fweisbec at gmail.com>:
>> 2013/2/21 Kevin Hilman <khilman at linaro.org>:
>>> Subject: [PATCH 2/5] kernel_cpustat: convert to atomic 64-bit accessors
>>>
>>> Use the atomic64_* accessors for all the kernel_cpustat fields to
>>> ensure atomic access on non-64 bit platforms.
>>>
>>> Thanks to Mats Liljegren for CGROUP_CPUACCT related fixes.
>>>
>>> Cc: Mats Liljegren <mats.liljegren at enea.com>
>>> Signed-off-by: Kevin Hilman <khilman at linaro.org>
>>
>> Funny stuff, I thought struct kernel_cpustat was made of cputime_t
>> field. Actually it's u64. So the issue is independant from the new
>> full dynticks cputime accounting. It was already broken before.
>>
>> But yeah that's not the point, we still want to fix this anyway. But
>> let's just treat this patch as independant.

OK, I just sent an updated series based on your proposal.

Thanks for the review,

Kevin



More information about the linux-arm-kernel mailing list