[PATCH v3 01/12] gpio: pxa: identify ed mask reg with platform data

[Linus Walleij]

On Mon, Feb 18, 2013 at 6:12 AM, Haojian Zhuang
<haojian.zhuang at linaro.org> wrote:

> Avoid to judge whether edge mask register exists by CPU. Use platform
> data to identify it instead. The gpio edge mask register exists in MMP
> series SoC.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>
(...)
> +       pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
> +       if (!pdata)
> +               return -ENOMEM;
> +       if (of_find_property(np, "marvell,gpio-ed-mask", NULL))

Should you not use of_property_read_bool()?

Should you not also update some DT binding document for this?

Yours,
Linus Walleij