[PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

Wolfram Sang wsa at the-dreams.de
Thu Feb 21 05:48:10 EST 2013


On Fri, Feb 15, 2013 at 03:18:35PM -0800, Doug Anderson wrote:
> There is simply no reason to be manually setting the private driver
> data to NULL in the remove/fail to probe cases.  This is just extra
> cruft code that can be removed.
> 
> A few notes:
> * Nothing relies on drvdata being set to NULL.
> * The __device_release_driver() function eventually calls
>   dev_set_drvdata(dev, NULL) anyway, so there's no need to do it
>   twice.
> * I verified that there were no cases where xxx_get_drvdata() was
>   being called in these drivers and checking for / relying on the NULL
>   return value.
> 
> This could be cleaned up kernel-wide but for now just take the baby
> step and remove from the i2c subsystem.
> 
> Reported-by: Wolfram Sang <wsa at the-dreams.de>
> Reported-by: Stephen Warren <swarren at wwwdotorg.org>
> Signed-off-by: Doug Anderson <dianders at chromium.org>

Applied, thanks!




More information about the linux-arm-kernel mailing list