[PATCH 2/2 v3] [RFC] ARM: shmobile: r8a7779: Add TMU02 platform device

Simon Horman horms at verge.net.au
Mon Feb 18 01:58:31 EST 2013


On Mon, Feb 18, 2013 at 02:38:32PM +0900, Magnus Damm wrote:
> On Mon, Feb 18, 2013 at 9:29 AM, Simon Horman
> <horms+renesas at verge.net.au> wrote:
> > This is intended primarily to exercise the TMUO2 clock definition
> > in clock-r8a7779.c. I would appreciate review before I queue it up or
> > drop it.
> 
> Why on earth would you want to queue this up? The TMU driver
> interfaces to the Linux kernel as clock event or clock source. We
> currently have one channel assigned as clock event, and another as
> clock source. Adding more channels does not really improve anything
> from a Linux kernel timer handling point of view.
> 
> However, say that you for some reason really enjoyed creating new
> platform devices then I recommend you to go all the way and hook up
> all 9 channels that are provided by the 3-channel TMU blocks TMU0,
> TMU1 and TMU2. Usually we stick to two channels though.

I will drop the change.



More information about the linux-arm-kernel mailing list