[PATCH] ARM:kernel: a bug by a redundancy charactor ';'

Dirk Behme dirk.behme at gmail.com
Sat Feb 16 03:04:28 EST 2013


Am 16.02.2013 07:49, schrieb Chen Gang:
>
>    delete the redundancy charactor ';', which will cause issue.
>
> Signed-off-by: Chen Gang <gang.chen at asianux.com>
> ---
>   arch/arm/kernel/perf_event.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c
> index 31e0eb3..a892067 100644
> --- a/arch/arm/kernel/perf_event.c
> +++ b/arch/arm/kernel/perf_event.c
> @@ -400,7 +400,7 @@ __hw_perf_event_init(struct perf_event *event)
>   	}
>
>   	if (event->group_leader != event) {
> -		if (validate_group(event) != 0);
> +		if (validate_group(event) != 0)
>   			return -EINVAL;
>   	}

Wondering against which branch this patch is, I found that this issue 
isn't in recent mainline from today, but in -next. Introduced by the patch

ARM: perf: simplify __hw_perf_event_init err handling
http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git;a=commitdiff;h=9dcbf466559f6f2f55d60eb5a1bbebc8e694b52a

While the subject/commit message could be improved (at least 
mentioning 'perf' somehow and charactor -> character), the change 
itself looks good.

Best regards

Dirk





More information about the linux-arm-kernel mailing list