[PATCH 03/35] mfd: ab8500-gpadc: Reread on failure

Lee Jones lee.jones at linaro.org
Fri Feb 15 07:56:34 EST 2013


From: Jonas Aaberg <jonas.aberg at stericsson.com>

Reread the gpadc once upon failure.

Signed-off-by: Jonas Aaberg <jonas.aberg at stericsson.com>
Signed-off-by: Lee Jones <lee.jones at linaro.org>
Reviewed-by: Mattias WALLIN <mattias.wallin at stericsson.com>
---
 drivers/mfd/ab8500-gpadc.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index 34c1d04..1b48ac1 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -259,6 +259,11 @@ int ab8500_gpadc_convert(struct ab8500_gpadc *gpadc, u8 channel)
 	int voltage;
 
 	ad_value = ab8500_gpadc_read_raw(gpadc, channel);
+
+	/* On failure retry a second time */
+	if (ad_value < 0)
+		ad_value = ab8500_gpadc_read_raw(gpadc, channel);
+
 	if (ad_value < 0) {
 		dev_err(gpadc->dev, "GPADC raw value failed ch: %d\n", channel);
 		return ad_value;
-- 
1.7.10.4




More information about the linux-arm-kernel mailing list