[PATCH] ARM: shmobile: r8a7779: Correct TMU clock support again

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Feb 13 23:25:45 EST 2013


Hi Simon

> > >>       CLKDEV_DEV_ID("sh_tmu.0", &mstp_clks[MSTP016]), /* TMU00 */
> > >> -     CLKDEV_DEV_ID("sh_tmu.1", &mstp_clks[MSTP015]), /* TMU01 */
> > >> +     CLKDEV_DEV_ID("sh_tmu.1", &mstp_clks[MSTP016]), /* TMU01 */
> > >>       CLKDEV_DEV_ID("sh_tmu.2", &mstp_clks[MSTP014]), /* TMU02 */
(snip)
> > This means that current TMU02 numbering seems doubtful too ?
> > How about just rever 58079fa7d54a0929d304054ee759187a2ccd3cdf ?
> 
> Perhaps that is a good idea.
> 
> The original motivation for this patch was to add the TMU02 line.
> And "fixing" TMU01 was an afterthought. However, I am also
> now doubtful about the correctness of the TMU02 line and thus
> the usefulness of the original patch.

I think this comment out is creating confusion ?

/* TMU00 */ -> /* TMU0 channel 0 */
/* TMU01 */ -> /* TMU0 channel 1 */
/* TMU02 */ -> /* TMU0 channel 2 */

Best regards
---
Kuninori Morimoto



More information about the linux-arm-kernel mailing list