[PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Tue Feb 12 05:58:36 EST 2013
I have not checked the code but there is a possibility that custom pool->lock
is not needed at all due to dma_pool contains it's own lock.
Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Cc: Linus Walleij <linus.walleij at linaro.org>
Cc: linux-arm-kernel at lists.infradead.org
---
drivers/dma/coh901318_lli.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/coh901318_lli.c b/drivers/dma/coh901318_lli.c
index 3e96610..702112d 100644
--- a/drivers/dma/coh901318_lli.c
+++ b/drivers/dma/coh901318_lli.c
@@ -61,7 +61,7 @@ coh901318_lli_alloc(struct coh901318_pool *pool, unsigned int len)
dma_addr_t phy;
if (len == 0)
- goto err;
+ return NULL;
spin_lock(&pool->lock);
--
1.7.10.4
More information about the linux-arm-kernel
mailing list