[PATCH V4] ARM: bcm281xx: Add timer driver

Christian Daudt csd at broadcom.com
Mon Feb 11 22:25:34 EST 2013


On 13-02-11 07:00 PM, Stephen Warren wrote:
> On 02/11/2013 04:44 PM, Christian Daudt wrote:
>> This adds support for the Broadcom timer, used in the following SoCs:
>> BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
>> diff --git a/drivers/clocksource/bcm_kona_timer.c b/drivers/clocksource/bcm_kona_timer.c
>> +static const struct of_device_id bcm_timer_ids[] __initconst = {
>> +	{.compatible = "bcm,kona-timer"},
>> +	{},
>> +};
>> +
>> +static void __init kona_timers_init(void)
>> +{
>> +	struct device_node *node;
>> +	u32 freq;
>> +
>> +	node = of_find_matching_node(NULL, bcm_timer_ids);
>> +
>> +	if (!node)
>> +		panic("No timer");
> I assume this is for 3.10 now.
Oh. I missed 3.9 window ? Got busy with other stuff. Oh well, try again.
> Can you rework this to remove
> bcm_timer_ids[] and that of_find_matching_node() call, and replace it
> with e.g.:
>
> CLOCKSOURCE_OF_DECLARE(kona, "bcm,kona-timer", kona_timer_init);
where can I find an example ? I looked throught armsoc/for-next and the 
code there has CLOCKSOURCE_OF_DECLARE but it still has 
of_find_matching_node calls in the init fns - is it still in the process 
of being removed ?

  Thanks,
    csd





More information about the linux-arm-kernel mailing list