[PATCH] ARM: OMAP: Clock: Remove CK_* flags

[J, KEERTHY]

Hi Paul,

> -----Original Message-----
> From: J, KEERTHY
> Sent: Monday, February 11, 2013 10:16 AM
> To: 'Paul Walmsley'
> Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> Subject: RE: [PATCH] ARM: OMAP: Clock: Remove CK_* flags
> 
> Hi Paul,
> 
> > -----Original Message-----
> > From: Paul Walmsley [mailto:paul at pwsan.com]
> > Sent: Saturday, February 09, 2013 12:29 AM
> > To: J, KEERTHY
> > Cc: linux-omap at vger.kernel.org; linux-arm-kernel at lists.infradead.org
> > Subject: RE: [PATCH] ARM: OMAP: Clock: Remove CK_* flags
> >
> > Hi Keerthy,
> >
> > On Fri, 8 Feb 2013, Paul Walmsley wrote:
> >
> > > On Fri, 8 Feb 2013, J, KEERTHY wrote:
> > >
> > > > Thanks for updating. Yes renaming the
> > > > 'omap_clocks_register_links() Is fine. I had blindly followed the
> > > > hwmod function naming
> > convention.
> > > > The new name makes sense.
> > >
> > > OK great.  BTW don't forget to cc the linux-arm-kernel mailing list
> > for
> > > all patches, otherwise we won't be able to merge the patches.
> > > Taking
> > care
> > > of it now in this case.
> >
> > Just noticed during final testing of this patch that it causes some
> > problems with power management on OMAP4460: (see the suspend/resume
> > messages)
> >
> 
> I understand that retention is broken from the logs.
> I first tried seeing if the retention is working without the patch And
> I see that even without the patch retention fails.
> 
> I am attaching the log.
> 
> I just want to confirm if the retention is working fine without
> Applying the patch on mainline.
> 
> Top Commit ID: 836dc9e3fbbab0c30aa6e664417225f5c1fb1c39
> Defconfig: omap2plus_defconfig
> 
> Am I missing something here?

That was a bootloader issue. I am able to see that the mainline uImage
Hits retention. I could not apply the updated version of this patch from
You. I guess the updated version is on top of other non merged patches.

I just applied the earlier version of this patch and saw that
Retention is fine on OMAP4460.

Can I pull the other patches and rebase this patch on top of them?
I need the branch where I can pull the other clock related patches.
I will rebase this patch on top, Verify the PM suspend on OMAP4460
And post it.

> 
> >
> http://www.pwsan.com/omap/testlogs/jk_clock_flags_cleanup_3.9/20130207
> > 1 83613/pm/4460pandaes/4460pandaes_log.txt
> >
> > Could you please take a look at this and see what happened?  I
> suspect
> > that I screwed something up as I was rebasing the patch.
> > Unfortunately I don't have the time to debug it further.
> >
> >
> > - Paul
> 
> Regards,
> Keerthy

Regards,
Keerthy