Latest additional build warnings

Tony Lindgren tony at atomide.com
Sat Feb 9 22:22:34 EST 2013


* Olof Johansson <olof at lixom.net> [130209 19:08]:
> On Sat, Feb 9, 2013 at 7:00 PM, Tony Lindgren <tony at atomide.com> wrote:
> > * Russell King - ARM Linux <linux at arm.linux.org.uk> [130209 03:53]:
> >> On Tue, Feb 05, 2013 at 02:22:18PM +0000, Russell King - ARM Linux wrote:
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall'
> >> > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration
> >> > arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used
> >>
> >> I'm still seeing the above in the build of Friday's merge.  I'm also
> >> seeing additional warnings in the randconfig similar to the above for
> >> arch/arm/mach-omap2/omap-iommu.c.
> >
> > Thanks for letting me know about the omap-iommu.c one. Looks like
> > there's also one patch for drm.c.
> >
> > Olof, if you did not yet apply the hwspinlock.c warning fix, I'll
> > just do a branch with all three of them for you.
> 
> I haven't (must have missed it), so please just send a branch.

OK will do. Probably you started fixing up the bad Reported-by
line in my patch and then got disrupted :)

Found one more after some grepping, after the following patch they
should be all fixed up. Pull request coming shortly.

Tony


From: Tony Lindgren <tony at atomide.com>
Date: Sat, 9 Feb 2013 19:20:57 -0800
Subject: [PATCH] ARCH: OMAP2+: Make sure files with omap initcalls include soc.h

Looks like there are few more places that I missed that can cause
compiler warnings. After grepping for omap initcall, all files
needing soc.h should now have it.

Reported-by: Russell King <rmk+kernel at arm.linux.org.uk>
Signed-off-by: Tony Lindgren <tony at atomide.com>

--- a/arch/arm/mach-omap2/omap-iommu.c
+++ b/arch/arm/mach-omap2/omap-iommu.c
@@ -16,6 +16,7 @@
 #include <linux/slab.h>
 
 #include <linux/platform_data/iommu-omap.h>
+#include "soc.h"
 #include "omap_hwmod.h"
 #include "omap_device.h"
 
--- a/arch/arm/mach-omap2/smartreflex-class3.c
+++ b/arch/arm/mach-omap2/smartreflex-class3.c
@@ -12,6 +12,7 @@
  */
 
 #include <linux/power/smartreflex.h>
+#include "soc.h"
 #include "voltage.h"
 
 static int sr_class3_enable(struct omap_sr *sr)



More information about the linux-arm-kernel mailing list