[PATCH 16/17] xgmac: replace __raw with relaxed IO
Ben Dooks
ben.dooks at codethink.co.uk
Sat Feb 9 17:03:52 EST 2013
On 09/02/2013 20:59, Rob Herring wrote:
> On 02/08/2013 05:17 PM, Ben Dooks wrote:
>> The xgmac driver is using __raw read and write functions, where it
>> should be using readl_relaxed and writel_relaxed to avoid any issues
>> with which endian mode the CPU is running in.
>>
>> Signed-off-by: Ben Dooks <ben.dooks at codethink.co.uk>
>> ---
>> drivers/net/ethernet/calxeda/xgmac.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> This will break on arches which don't have the _relaxed variants.
> David
> Miller will reject restricting this to build on ARM only. See this:
>
> http://www.spinics.net/lists/netdev/msg215457.html
I was considering changing it anyway to keep the __raw functions
and simply swapping the endian-ness of the data when necessary
as we don't need about three rev instructions in there where one
will do.
Will sort out looking at this when I am back in the office on Monday.
--
Ben
More information about the linux-arm-kernel
mailing list