[PATCH 1/1] DMA: PL330: allow submitting 2 requests at a time

Jassi Brar jassisinghbrar at gmail.com
Thu Feb 7 06:31:14 EST 2013


On Thu, Feb 7, 2013 at 4:08 PM, Alvaro Moran <dirac3000 at gmail.com> wrote:
> Due to the original driver design, only one request was processed at a
> time by the driver, even if the low-level part of the driver was able to
> handle 2 requests.
> With this patch we are able to create 2 microcodes per thread and to
> launch the second transfer on the interrupt handler of the first one,
> instead of having to wait for the tasklet to generate the microcode.
>
The following seems more appropriate and complete. Does it fix your problem?

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 758122f..a821d71 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2292,13 +2292,12 @@ static inline void fill_queue(struct
dma_pl330_chan *pch)

 		/* If already submitted */
 		if (desc->status == BUSY)
-			break;
+			continue;

 		ret = pl330_submit_req(pch->pl330_chid,
 						&desc->req);
 		if (!ret) {
 			desc->status = BUSY;
-			break;
 		} else if (ret == -EAGAIN) {
 			/* QFull or DMAC Dying */
 			break;



More information about the linux-arm-kernel mailing list