[PATCH 03/14] mfd: ab8500: ensure new AB8500 pinctrl driver is probed correctly

Stephen Warren swarren at wwwdotorg.org
Wed Feb 6 19:08:54 EST 2013


On 02/05/2013 12:48 PM, Linus Walleij wrote:
> From: Lee Jones <lee.jones at linaro.org>
> 
> The old, BROKEN AB8500 GPIO driver has been revamped as a shiny
> new pinctrl driver and has been renamed as such. So, if we would
> like to make use of it, we need to register it via its new name.

> diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c

>  static struct mfd_cell ab8500_devs[] = {
>  	{
> -		.name = "ab8500-gpio",
> +		.name = "pinctrl-ab8500",
>  		.of_compatible = "stericsson,ab8500-gpio",
>  	},

I assume that the GPIO/pinctrl driver has already been renamed in some
unrelated patch, so this patch is just fixing it so it works again?

If I'm not understanding correctly, doesn't this patch break "git
bisect", since it's only renaming it in the MFD core and not in the
driver that this expects to instantiate?




More information about the linux-arm-kernel mailing list