[GIT PULL 2/5] Samsung cleanup-s3c24xx for v3.9

Kukjin Kim kgene.kim at samsung.com
Tue Feb 5 19:54:28 EST 2013


Olof Johansson wrote:
> 
> On Mon, Feb 04, 2013 at 03:41:55PM -0800, Kukjin Kim wrote:
> > Hi Arnd and Olof,
> >
> > Here is 2nd cleanup for Samsung S3C24XX stuff and based on previous
> > pull-request branch, 'next/cleanup-header'.
> > Basically, this patch merges mach-s3c2410, mach-s3c2412 and mach-s3c2440
> > into mach-s3c24xx.
> >
> > Note, this is 2nd pull request and first is 'next/cleanup-header'
branch.
> > If any problems, please let me know.
> 
> Hi,
> 
Hi,

> So, your first pull request didn't contain a "1/5", so it's hard to match
them
> up.
> 
Could be, sorry for that.

> Also, see how the word wrapping looks below? I wonder if you run your "git
> request-pull" in a terminal window that is wider than 80 characters, and
then
> copy-and-paste it over? That doesn't work well. (I suspect you do since
your
> git URL is always wrapped too :( )
> 
Yeah, I know...sigh, it's hard to me how to avoid wrapped git URL...anyway
let me check it more closely from now on.

> Finally, would you mind starting to use signed tags with branch
descriptions,

Hmm, I see...but unfortunately, I can't use signed tag in my office, because
I can't use my own laptop in my office due to company security. Let me find
the way but probably need more time to use it.

> or at least give a short overview of the branches in the pull requests?
> 
OK, let me add it next time.

So you want to re-send this pull request? Even though I'm not sure how I can
cover your ask except a short overview...

Thanks.

- Kukjin




More information about the linux-arm-kernel mailing list