[PATCH v2] rtc: rtc-mv: Add support for clk to avoid lockups

Simon Baatz gmbnomis at gmail.com
Sun Feb 3 14:44:07 EST 2013


Hi Andrew,

On Sun, Feb 03, 2013 at 12:32:06PM +0100, Andrew Lunn wrote:
> The Marvell RTC on Kirkwood makes use of the runit clock. Ensure the
> driver clk_prepare_enable() this clock, otherwise there is a danger
> the SoC will lockup when accessing RTC registers with the clock
> disabled.
> 
> Reported-by: Simon Baatz gmbnomis at gmail.com
> Signed-off-by: Andrew Lunn <andrew at lunn.ch>

And:

Tested-by: Simon Baatz <gmbnomis at gmail.com>

Btw, <...> is missing from the email address in the Reported-by line.

Thanks for providing this so quickly. Now, it looks like this
(without applying the GPIO fix, yet, because it would already enable
the runit clock):

# cat /sys/kernel/debug/clk/tclk/runit/clk_enable_count
0
# insmod ./rtc-mv.ko
# cat /sys/kernel/debug/clk/tclk/runit/clk_enable_count
1
# hwclock
Sun Feb  3 19:34:53 2013  -1.003522 seconds
# rmmod rtc-mv
# cat /sys/kernel/debug/clk/tclk/runit/clk_enable_count
0


- Simon



More information about the linux-arm-kernel mailing list