[PATCH] rtc: rtc-mv: Add support for clk to avoid lockups

Andrew Lunn andrew at lunn.ch
Sun Feb 3 06:14:15 EST 2013


> > +	pdata->clk = devm_clk_get(&pdev->dev, NULL);
> > +	/* Not all SoCs require a clock.*/
> > +	if (!IS_ERR(pdata->clk))
> > +		clk_prepare_enable(pdata->clk);
> > +
> 
> There are already I/O accesses to the RTC above this. Thus, you
> probably need to move this up.

Doh!

I was trying to keep the cleanup on error simple....

Thanks
	Andrew



More information about the linux-arm-kernel mailing list