[PATCH] ARM: OMAP: Fix the use of uninitialized dma_lch_count

Tony Lindgren tony at atomide.com
Fri Feb 1 17:40:32 EST 2013


* Santosh Shilimkar <santosh.shilimkar at ti.com> [130111 03:40]:
> On Friday 11 January 2013 11:09 AM, Chen Gang wrote:
> >
> >   'omap_dma_reserve_channels' when used is suppose to be from command.
> >     so, it alreay has value before 1st call of omap_system_dma_probe.
> >     and it will never be changed again during running (not from ioctl).
> >
> >   but 'dma_lch_count' is zero before 1st call of omap_system_dma_probe.
> >     so it will be failed for omap_dma_reserve_channels, when 1st call.
> >
> >   so, need use 'd->lch_count' instead of 'dma_lch_count' for judging.
> >
> >Signed-off-by: Chen Gang <gang.chen at asianux.com>
> >Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
> >---
> Looks fine to me.
> 
> Tony,
> If you are ok with the patch, can you pick this fix in your
> non-critical fixes branch ?

Yes applying thanks.

Tony



More information about the linux-arm-kernel mailing list