[PATCHv2 for soc 3/4] arm: Add v7_invalidate_l1 to cache-v7.S
Santosh Shilimkar
santosh.shilimkar at ti.com
Fri Feb 1 09:43:34 EST 2013
On Friday 01 February 2013 08:01 PM, Russell King - ARM Linux wrote:
> Just to further provide some insight into the reasoning:
>
> Invalidating data out of a working cache risks data corruption; maybe
> the data being invalidated is filesystem metadata which was about to
> be cleaned and written back to storage. That risks filesystem
> corruption.
>
> Invalidating fewer levels than are actually required is different: we
> may leave dirty cache lines behind which may be evicted, but there's
> also the chance that the CPU will end up _reading_ from its
> uninitialized caches and may crash before that happens.
>
> So, the risks are:
> 1. invalidate more levels than are necessary and risk discarding data
> which other CPUs are using, which may be important data.
> 2. invalidate less levels than are necessary and risk writing out
> data from the CPU cache, which may or may not happen _before_ the
> CPU crashes due to reading invalid data.
>
> Out of those two, (2) sounds to me to be the safer approach.
>
> Plus, I can't think of a reason why you'd want to put on a SMP system
> more than one layer of CPU local caches... to do so would seem to me to
> be an exercise in coherency complexity... So, I suspect that in the
> real world, we will _never_ see any system which has more than one
> layer of caches local to the CPU. But we may see a system with a
> cache architecture similar to the one I drew in my email to Santosh.
>
I still scratching my head on why you would even have a CPU design
with two L2 shared caches for a 4 CPU system.
If you ever design such a system, you need to ensure that
1. Both L2 are used in exclusive mode
2. Both L2 cache has coherency hardware connected to keep them in sync
for shared data.
For 1, one would just increase the size of L2 and have only 1 memory.
2 Doesn't bring much advantage unless and until your L3 is too far
away for access in terms of CPU access cycles.
Regards
Santosh
More information about the linux-arm-kernel
mailing list