[PATCHv2 for soc 3/4] arm: Add v7_invalidate_l1 to cache-v7.S
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Feb 1 07:54:17 EST 2013
On Fri, Feb 01, 2013 at 12:11:38PM +0000, Lorenzo Pieralisi wrote:
> Well, on latest processors (A15, A7) caches are invalidated on reset unless
> the chip is programmed to skip that on reset (ie L2 retained).
>
> But it makes sense, for sure it should not be called v7_invalidate_l1,
> but invalidate_louis, and instead of forcing level 0 we should be
> reading LoUIS and invalidate up to that level as we do in the clean and
> invalidate function.
No. Think about it. c7, c6, 2 _invalidates_ the cache. That means any
data contained within the cache is discarded. Data is not written back.
If you do this down to the LoUIS, that includes all cache levels in the
inner sharable domain. The inner sharable domain includes the other CPUs
in the system which may already be running (certainly the boot CPU will
be running).
Are you _really_ sure you want to be invalidating _valid_ data held in
caches in the inner sharable domain by other CPUs, rather than just the
cache associated with the CPU which is being brought online?
More information about the linux-arm-kernel
mailing list