[PATCH v3 2/2] ARM: kirkwood: Add standby support

[Jason Cooper]

On Fri, Aug 30, 2013 at 08:10:04PM -0300, Ezequiel Garcia wrote:
> On Thu, Aug 22, 2013 at 12:49:07PM -0300, Ezequiel Garcia wrote:
> > Implements standby support for Kirkwood SoC. When the SoC enters
> > standby state the memory PM units are disabled, the DDR is set
> > in self-refresh mode, and the CPU is set in WFI.
> > 
> > At this point there's no clock gating, as that is considered each
> > driver's task.
> > 
> > Signed-off-by: Simon Guinot <sguinot at lacie.com>
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> > ---
> >  arch/arm/mach-kirkwood/Makefile                   |  2 +
> >  arch/arm/mach-kirkwood/board-dt.c                 |  1 +
> >  arch/arm/mach-kirkwood/common.c                   |  1 +
> >  arch/arm/mach-kirkwood/common.h                   |  6 ++
> >  arch/arm/mach-kirkwood/include/mach/bridge-regs.h |  2 +
> >  arch/arm/mach-kirkwood/pm.c                       | 73 +++++++++++++++++++++++
> >  6 files changed, 85 insertions(+)
> >  create mode 100644 arch/arm/mach-kirkwood/pm.c
> 
> Any comments on this?

Well, I was sitting on this for the next merge window, since it came in
late and honestly, isn't complete.  You stated yourself in the
coverletter that it offered no real power savings.

How about expanding the series to add proper suspend/resume support to
some of the more power hungry drivers (yes, this might re-awaken the
mv643xx_eth mac address issue), and resubmit?

thx,

Jason.