[PATCH 10/14] ARM: shmobile: Rename to emev2_init_early(), use smp_set_ops()

Magnus Damm magnus.damm at gmail.com
Wed Aug 28 03:03:23 EDT 2013

Hi Laurent,

On Fri, Aug 9, 2013 at 7:41 PM, Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
> Hi Magnus,
> Thank you for the patch.
> On Friday 09 August 2013 18:49:36 Magnus Damm wrote:
>> From: Magnus Damm <damm at opensource.se>
>> Rename emev2_init_delay() into emev2_init_early()
>> to make the function name show that more than just
>> delay setup will happen.
>> Also, instead of specifying the smp ops in DT_MACHINE
>> convert the EMEV2 SoC code to install the smp ops
>> from emev2_init_early().
> Could you please explain in the commit message why this is needed ? Same
> comment for the other patches in this series.

I personally think it is neat to use as few callbacks as possible in
the DT_MACHINE. Hooking in SMP ops in ->init_early() means that the
boards now are unaware if SMP is used or not - and it makes sense to
me to write board code that is independent of SMP.

Anyway, I suspect that Olof prefers to use smp_ops() instead, so I
think these patches just should be dropped.

/ magnus

More information about the linux-arm-kernel mailing list