[PATCH 01/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Tue Aug 27 10:39:39 EDT 2013


Dear Ezequiel Garcia,

On Tue, 27 Aug 2013 11:34:25 -0300, Ezequiel Garcia wrote:
> With the introduction of the orion irqchip driver, now the BRIDGE_CAUSE
> bit is cleared by it. There's no longer a need to do it in the watchdog
> driver, so we can simply remove it.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>

Is this going to work with the platforms that use the orion_wdt driver
but are not using the orion irqchip driver? Take for example
mach-orion5x, it still uses the plat-orion/irq.c code and not the
irqchip orion driver, as far as I can see.

The orion irqchip driver is DT only, so all of the Orion platforms that
have not been converted to DT are still using the old irq code.

Any thoughts on the consequences of this in relation with your patch?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com



More information about the linux-arm-kernel mailing list