[PATCH] ARM: OMAP: fix return value check in omap_device_build_from_dt()

Kevin Hilman khilman at linaro.org
Mon Aug 26 20:10:41 EDT 2013


Tony Lindgren <tony at atomide.com> writes:

> Kevin,
>
> * Wei Yongjun <weiyj.lk at gmail.com> [130704 06:48]:
>> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
>> 
>> In case of error, the function omap_device_alloc() returns ERR_PTR()
>> and never returns NULL. The NULL test in the return value check
>> should be replaced with IS_ERR().
>
> Looks like this is still pending, care to take this?

Acked-by: Kevin Hilman <khilman at linaro.org>

Looks fine to me, since I don't have anything else in the queue, feel
free to queue up for fixes-non-critical.

Kevin



More information about the linux-arm-kernel mailing list