[PATCH v4 2/5] mmc: atmel-mci: prepare clk before calling enable
b.brezillon at overkiz.com
Sun Aug 25 01:35:18 EDT 2013
On 25/08/2013 05:18, Chris Ball wrote:
> On Thu, Jul 18 2013, Boris BREZILLON wrote:
>> Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to
>> avoid common clk framework warnings.
>> Signed-off-by: Boris BREZILLON <b.brezillon at overkiz.com>
>> Acked-by: Ludovic Desroches <ludovic.desroches at atmel.com>
> Okay, pushed to mmc-next for 3.12.
> Boris, you got feedback from Thomas Petazzoni and Russell King, but
> you didn't CC either of them on the patch v4
I didn't knew I had to add the reviewers of a patch in the cc list
of the future versions. I'll do it next time.
> , and you didn't write a
> changelog explaining the differences between patches v3 and v4 --
> please do both of those next time.
The changelog is in the cover letter ("Changes since v3").
But I didn't send you this cover letter.
> Also, it looks like the Ack from Ludovic happened away from the MMC
> list, since I don't see a message from Ludovic on the thread here.
> It would be better if the Ack happened somewhere I can see it.
The 'Acked-by: Ludovic Desroches <ludovic.desroches at atmel.com>' was added
in the 2nd version of this patch series.
But I don't know if I should have kept it in this version since this
patch has evolved.
Thanks for these feebacks, I'm still learning the good practices of the
I'll check these points next time.
> - Chris.
More information about the linux-arm-kernel