[PATCH v7 05/11] ARM: dts: enable hi4511 with device tree

Kevin Hilman khilman at linaro.org
Thu Aug 22 14:07:26 EDT 2013


[+ DT maintainers]

Haojian Zhuang <haojian.zhuang at linaro.org> writes:

> Enable Hisilicon Hi4511 development platform with device tree support.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>

There seems to be use of several new vendor-specific bindings here that
are not documented anywhere:

hisilicon,sctrl 
hisilicon,pmctrl
hisilicon,clk-mux
hisilicon,clk-div
hisilicon,clk-gate

Not only that, the clock-related compatible properties used here are
different than the ones specificed PATCH 10/11 of this series where you
document some clock bindings.  

also...

[...]

> +/include/ "skeleton.dtsi"
> +
> +/ {
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +		serial2 = &uart2;
> +		serial3 = &uart3;
> +		serial4 = &uart4;
> +	};
> +
> +	cpus {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		cpu0: cpu at 0 {
> +			device_type = "cpu";
> +			compatible = "arm,cortex-a9";
> +			reg = <0x0>;
> +			next-level-cache = <&L2>;
> +		};
> +	};
> +
> +	osc32k: osc32k {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <32768>;
> +		clock-output-names = "osc32khz";
> +	};

...seems many of the recent users of clocks have grouped them into a
clocks {} grouping on a "simple-bus".

DT folks: is there a rule of thumb on how whether these fixed clocks
should be grouped on a simple bus?

Kevin



More information about the linux-arm-kernel mailing list