[PATCH v2 2/4] iio: at91: Use different prescal, startup mask in MR for different IP

[Josh Wu]

Add Ludovic in the loop.

On 8/22/2013 5:51 PM, Josh Wu wrote:
> Hi, Maxime
>
> On 8/16/2013 3:20 AM, Maxime Ripard wrote:
>> Hi Josh,
>>
>> On Sun, Aug 11, 2013 at 07:04:29PM +0800, Josh Wu wrote:
>>> For at91 boards, there are different IPs for adc. Different IPs has
>>> different STARTUP & PRESCAL mask in ADC_MR.
>>>
>>> This patch introduce the multiple compatible string for those
>>> different IPs.
>>>
>>> Signed-off-by: Josh Wu <josh.wu at atmel.com>
>> Overall it looks like the right ways, but I think we can take it a step
>> further.
>>
>> I'd drop at least the atmel,adc-drdy-mask, atmel,adc-num-channels,
>> atmel,adc-status-register, atmel,adc-trigger-register properties (and
>> probably the triggers as well description as well).
>
> yeah, right. Currently I want to drop following:
>
> atmel,adc-drdy-mask, atmel,adc-status-register, 
> atmel,adc-trigger-register, atmel,adc-channel-base
>
> For the adc-num-channels, I'd like to leave it in dt parameters. It is 
> a description for an adc capablity.
>
> For the triggers, I am not decided. An obvious benifit to remove 
> trigger in dt will save many lines of code.
>
>>
>> Maxime
>>
>
> Best Regards,
> Josh Wu