[PATCH v2] ARM: OMAP2: use 'int' instead of 'unsigned' for variable 'gpmc_irq_start'
Tony Lindgren
tony at atomide.com
Thu Aug 22 03:57:32 EDT 2013
* Chen Gang <gang.chen at asianux.com> [130822 00:55]:
> 'gpmc_irq_start' is mostly used as 'int', and for a variable, do not
> suggest to only use 'unsigned' as its type, so use 'int' instead of
> 'unsigned' for variable 'gpmc_irq_start'.
>
> Also it will fix the related issue (dummy the real world failure):
>
> arch/arm/mach-omap2/gpmc.c:728:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>
Thanks applying into omap-for-v3.12/fixes-non-critical.
Tony
> Signed-off-by: Chen Gang <gang.chen at asianux.com>
> ---
> arch/arm/mach-omap2/gpmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index f3fdd6a..9f4795a 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -149,7 +149,7 @@ struct omap3_gpmc_regs {
>
> static struct gpmc_client_irq gpmc_client_irq[GPMC_NR_IRQ];
> static struct irq_chip gpmc_irq_chip;
> -static unsigned gpmc_irq_start;
> +static int gpmc_irq_start;
>
> static struct resource gpmc_mem_root;
> static struct resource gpmc_cs_mem[GPMC_CS_NUM];
> --
> 1.7.7.6
More information about the linux-arm-kernel
mailing list